perfcollect does not process nolttng flag correctly

dotnet / corefx-tools

Place to include various misc tools for .NET and .NET Core.

MIT License

58 stars 41 forks source link

Open mausch opened 5 years ago

mausch commented 5 years ago

In a system without lttng ./perfcollect collect sampleTrace -nolttng errors out with "LTTng not installed. Install LTTng to proceed."

This is because in the script EnsurePrereqsInstalled comes before ProcessArguments has a chance to set useLTTng=0

workaround: sed -ie 's/useLTTng=1/useLTTng=0/' perfcollect

mausch commented 5 years ago

hmm I see someone has already sent a PR fixing this https://github.com/dotnet/corefx-tools/pull/75