search

dotnet / corefx-tools

Place to include various misc tools for .NET and .NET Core.
MIT License
58 stars 41 forks source link

Add GCWithHeap option to perfcollect #96

Closed sywhang closed 5 years ago

sywhang commented 5 years ago

This also removes GCJoin and PinObjectAtGCTime events from GCCollectOnly option.

For #65.

cc @noahfalk @brianrob @maoni0

brianrob commented 5 years ago

@sywhang thanks for doing this. Just saw this change in my inbox. Can you tell me what kind of testing you did on this?

sywhang commented 5 years ago

@brianrob I tested it on my local box to verify we're not getting the events we don't want on GCCollectOnly option as well as the new option I just added. One thing I wanted to ask you - do we have any automated tests for perfcollect? If so I'd like to know where/how to run it because I couldn't find it in this repo.