[DRAFT] 2930 Add Half support to Microsoft.Data.Analysis

dotnet / corefxlab

This repo is for experimentation and exploring new ideas that may or may not make it into the main corefx repo.

MIT License

1.46k stars 345 forks source link

[DRAFT] 2930 Add Half support to Microsoft.Data.Analysis #3001

Closed kevin-wittmer closed 3 years ago

kevin-wittmer commented 3 years ago

Opening this as a draft PR to get initial feedback. Some of the unit tests are currently failing because the Microsoft.ML.Data library does not yet have support for the Half data type.

Fixes #2930

kevin-wittmer commented 3 years ago

@pgovind Can you review this PR please?

pgovind commented 3 years ago

Apologies, I completely missed the notification for this PR. Will review first thing tomorrow!

kevin-wittmer commented 3 years ago

@pgovind No worries, thank you!

kevin-wittmer commented 3 years ago

@pgovind Any thoughts?

pgovind commented 3 years ago

I'm halfway through reviewing this PR. Just a note to myself to move the PR to dotnet/machinelearning.