Reorganize DLL imports - Githubissues

dotnet / corert

This repo contains CoreRT, an experimental .NET Core runtime optimized for AOT (ahead of time compilation) scenarios, with the accompanying compiler toolchain.

http://dot.net

MIT License

2.91k stars 508 forks source link

Reorganize DLL imports #2241

Open jkotas opened 7 years ago

jkotas commented 7 years ago

corefx switched back to PInvokes using classic Windows .dll names: https://github.com/dotnet/corefx/pull/13440

We should do the same for CoreRT.

morganbr commented 7 years ago

We need to understand how this will affect using these libraries on Windows Server Core and in UWP applications.

jkotas commented 7 years ago

ProjectN is running with CoreFX bits that link against kernel32.dll already. There should not be a problem with doing this cleanup in CoreRT.

morganbr commented 7 years ago

I'm not sure those bits have shipped... I'd suggest confirming whether P/Invokes for kernel32 pass WACK and work on all of the OSes ProjectN supports, including all supported versions of Windows 10 desktop, Phone, XBox, HoloLens, and IoT.

jkotas commented 7 years ago

@yizhang82 have investigated this before corefx switched over, and concluded that we should be ok. We would not have switched corefx over otherwise.