search

dotnet / corert

This repo contains CoreRT, an experimental .NET Core runtime optimized for AOT (ahead of time compilation) scenarios, with the accompanying compiler toolchain.
http://dot.net
MIT License
2.91k stars 508 forks source link

Error on tests/runtest.sh -coreclr All #8362

Open Rattenkrieg opened 4 years ago

Rattenkrieg commented 4 years ago

Tested on Fedora 32, as per runtest.cmd should affect Windows as well. On "all" selection -test_filter_path parameter for tests/CoreCLR/runtest.py is omitted and we getting into this branch: https://github.com/dotnet/corert/blob/b06c72e12f24523dfe58717328a3de1b9f37a397/tests/CoreCLR/runtest.py#L1873-L1874 There is no tests/issues.targets file. Probably this one meant to be used but somehow wasn't added. Git history gives no clue. I see this wasn't detected because tests/runtest.sh -coreclr defaults to Top200.

MichalStrehovsky commented 4 years ago

I don't think anyone ran all CoreCLR Pri-0 tests on Linux before.

We're in the process of migrating the repo to dotnet/runtimelab where we will use the same test runner as CoreCLR. Most of it should already work, but haven't looked at failures yet.

Why are you interested in running these?

Rattenkrieg commented 4 years ago

Why are you interested in running these?

Wanted to contribue, I guess I have fix for #8246 and now looking to test it properly. Btw I borrowed issues.targets from CoreCLR and had really hot ~90 mins running it. I never thought I would want swap partition enabled until my Firefox and VsCode were killed during test run. Most of the tests have failed for obvious reasons.

MichalStrehovsky commented 4 years ago

Running all the tests only adds marginal value over what we enable in the CI - if you have something, we would be happy for a pull request!