dotnet / corert

This repo contains CoreRT, an experimental .NET Core runtime optimized for AOT (ahead of time compilation) scenarios, with the accompanying compiler toolchain.
http://dot.net
MIT License
2.91k stars 508 forks source link

prevent runtime shutdown while foreground threads keep running #8364

Closed Rattenkrieg closed 4 years ago

Rattenkrieg commented 4 years ago

Simplified logic adopted from CoreCLR with no additional states like m_UnstartedThreadCount, m_PendingThreadCount etc.

Rattenkrieg commented 4 years ago

I guess we are done @jkotas

jkotas commented 4 years ago

This repo is getting archived soon. Would you mind to resubmit this PR against https://github.com/dotnet/runtimelab/tree/feature/NativeAOT ? I would have to manually port it and fix it up otherwise.

jkotas commented 4 years ago

The change looks great to me otherwise. Thank you!

Rattenkrieg commented 4 years ago

Thanks for your feedback!

This repo is getting archived soon. Would you mind to resubmit this PR against https://github.com/dotnet/runtimelab/tree/feature/NativeAOT ? I would have to manually port it and fix it up otherwise.

Sure. I think it will be convenient if I address your recent comments here and submit PR to runtimelab once it "LGTM".

jkotas commented 4 years ago

Yes, that's fine.

jkotas commented 4 years ago

Superseded by https://github.com/dotnet/runtimelab/pull/235