search

dotnet / crank

Benchmarking infrastructure for applications
MIT License
976 stars 103 forks source link

Update SQL client version #646

Closed javiercn closed 11 months ago

javiercn commented 11 months ago

Make component governance happy

sebastienros commented 11 months ago

My concern is that the notification mentions System.Data.SqlClient 4.8.2 but it was already on 5.1.0, so I don't know how it is finding it and how this PR will be better. Maybe because I had not done a release on NuGet since then.

javiercn commented 11 months ago

@sebastienros we might need to do a bit more. The underlying culprit is the Azure.Identity dependency

sebastienros commented 11 months ago

That helps, it means I just need to add a reference to it in the agent's csproj (if that works). Will also send a PR to the projects that introduce it.