dotnet / crank

Benchmarking infrastructure for applications
MIT License
975 stars 103 forks source link

source.branchOrCommit broken #679

Closed sebastienros closed 8 months ago

sebastienros commented 8 months ago

It doesn't flow to sources.default.

Repro:

crank --config https://github.com/aspnet/Benchmarks/blob/main/src/BenchmarksApps/TechEmpower/BlazorSSR/blazorssr.benchmarks.yml?raw=true --config https://raw.githubusercontent.com/aspnet/Benchmarks/main/build/azure.profile.yml --config https://raw.githubusercontent.com/aspnet/Benchmarks/main/scenarios/steadystate.profile.yml --config https://raw.githubusercontent.com/aspnet/Benchmarks/main/build/ci.profile.yml --scenario fortunes --profile intel-lin-app --profile intel-load-load --profile intel-db-db --application.framework net8.0 --application.options.collectCounters true --application.collectDependencies true --application.aspNetCoreVersion 8.0.0-preview.5.23269.8 --application.runtimeVersion 8.0.0-preview.5.23269.11 --application.sdkVersion 8.0.100-preview.5.23269.37 --application.source.branchOrCommit #8a64d007da339b9cb42efb2074144e48c802107b

Will fail the build, it should pass if the correct commit was taken into account.

The json payload is pointing to main instead of 8a64d007da339b9cb42efb2074144e48c802107b

    "sources": {
        "default": {
            "branchOrCommit": "main",
            "repository": "https://github.com/aspnet/benchmarks.git",
sebastienros commented 8 months ago

@caaavik-msft

caaavik-msft commented 8 months ago

The cause of this was that the command was being run in powershell and the # was being interpreted as a powershell comment. The workaround is to surround the argument with double quotes.