dotnet / crank

Benchmarking infrastructure for applications
MIT License
975 stars 103 forks source link

Remove alternate spellings of "-d" and "-w" from wrk invocations. #685

Open RobertHenry6bev opened 8 months ago

RobertHenry6bev commented 8 months ago

wrk can be invoked with arg "-d" or "--duration". Likewise "-w" and "--warmup". Allow this. This fix isn't very elegant, and is not applied uniformly to the wrk2 and other loadgenerators.

sebastienros commented 7 months ago

wrk can be invoked with arg "-d" or "--duration"

You mean wrk or the wrk wrapper (Crank.Wrk). Same question for -w / --warmup

Allow this.

I don't understand what it's "allowing" since the previous sentence says "Can". Can you explain what the PR is fixing or improving?