dotnet / crank

Benchmarking infrastructure for applications
MIT License
975 stars 103 forks source link

Revert jobs to use source instead of sources #699

Closed caaavik-msft closed 6 months ago

caaavik-msft commented 6 months ago

Reverts the jobs that are defined inside this repo to use source instead of sources. In my recent change (link), I made it so that all the jobs such as wrk, bombardier, wrk2 etc. used sources instead of source. This commit also included a bug fix which is required for this change to work or it would throw an error. Anyone using a crank controller which does not have the bug fix yet will get the following error:

$ crank --config https://raw.githubusercontent.com/aspnet/Benchmarks/main/scenarios/plaintext.benchmarks.yml --scenario plaintext --profile aspnet-perf-lin
The service 'load' is missing some properties to start the job.
Check that any of these properties is set: project, executable, dockerFile, dockerLoad, dockerPull

This PR temporarily reverts the jobs to use source instead of sources until we are confident that anyone using crank has installed the latest version which has the bug fix.