search

dotnet / crank

Benchmarking infrastructure for applications
MIT License
970 stars 103 forks source link

BuildFiles arent uploaded correctly #725

Open anna-git opened 4 months ago

anna-git commented 4 months ago

buildFiles:

Most of the files are not uploaded. Although in the logs they appeared succesfully uploaded, we receive 200. Only .xml and .conf extensions are uploaded. Other types like dll, .so are never uploaded

sebastienros commented 4 months ago

Can you check if you have a .gitignore file that could filter that out? Try to remove it if so and see if that still happen. I don't think "buildfiles" argument should do that but that could be the reason

anna-git commented 4 months ago

even with an empty .gitignore, the files are still not present 🤔

sebastienros commented 4 months ago

Thanks, I will try to repro. Note that "buildFiles" should be source code, required for the build step. If you are trying to upload dll/so files then you should use outputFiles instead.

anna-git commented 4 months ago

Example of files in source: -rw-r--r-- 1 ubuntu ubuntu 8577 Mar 27 18:40 MyFile.deps.json -rw-r--r-- 1 ubuntu ubuntu 20992 Mar 27 18:40 MyFile.dll -rw-r--r-- 1 ubuntu ubuntu 13664 Mar 27 18:40 MyFile.pdb -rw-r--r-- 1 ubuntu ubuntu 1291 Mar 27 18:40 MyFile.MSBuild.xml -rw-r--r-- 1 ubuntu ubuntu 6986752 Mar 27 18:40 MyFile.dll -rw-r--r-- 1 ubuntu ubuntu 2425664 Mar 27 18:40 MyFile.pdb -rw-r--r-- 1 ubuntu ubuntu 5922784 Mar 27 18:40 MyFile.xml

Only the smallest one is uploaded on destination: -rw------- 1 ubuntu ubuntu 1291 Mar 27 18:40 MyFile.MSBuild.xml

anna-git commented 4 months ago

Ok I'll try output files thanks

anna-git commented 4 months ago

seems to be the same 🤔

anna-git commented 4 months ago

the thing is we used them like that:

          buildFiles:
          - "../../binaries/**;{{ linuxPath }}/{{ commit_hash }}/binaries"

if I replace buildFiles with outputFiles the files dont seem to be copied in the right destination anymore. In the logs, we just see 

File added: ../../binaries/net6.0/MyFile.deps.json

Before we used to see: 

[09:02:13.616] Uploading ../../binaries/net6.0/MyFile.deps.json;/home/ubuntu/2c36cb68fd3cebe2380efe2cb983e3d9386c8d75/binaries/MyFile.deps.json (5KB)

I dont know if outputFiles support destinations the same..

anna-git commented 4 months ago

but in any case all dll / so files are missing without Outfiles as well even if it says it's adding them 🤔