search

dotnet / crank

Benchmarking infrastructure for applications
MIT License
970 stars 103 forks source link

Add certificate based authentication #735

Closed DrewScoggins closed 2 months ago

DrewScoggins commented 3 months ago

This PR add support for using certificates to authenticate for the Crank controller, agent, and ServiceBusAgent. It does not add support for using certificates to authenticate Azure relay.

sebastienros commented 2 months ago

@DrewScoggins can you check my feedback?

DrewScoggins commented 2 months ago

Sorry for the delay in responding to this feedback, but I think I have addressed all the feedback. This PR is also not complete because we need to also add managed identity support, as that is how the ASP.NET lab is going to function.

mkArtakMSFT commented 2 months ago

Sorry for the delay in responding to this feedback, but I think I have addressed all the feedback. This PR is also not complete because we need to also add managed identity support, as that is how the ASP.NET lab is going to function.

Thanks for the update, @DrewScoggins. @sebastienros do we need a change from our side here, or should this merge first and then we follow-up with a separate PR?