dotnet / csharp-notebooks

Get started learning C# with C# notebooks powered by .NET Interactive and VS Code.
MIT License
1.03k stars 344 forks source link

ML Notebook improvements #39

Open luisquintanilla opened 2 years ago

luisquintanilla commented 2 years ago

Thanks @andrasfuchs for trying out the notebooks and providing feedback:

This feedback is specific to the Training and AutoML notebook, but it's also good feedback in general to follow across notebooks.

luisquintanilla commented 2 years ago

@LittleLittleCloud do you know why the grey box / exception might be happening?

JakeRadMSFT commented 2 years ago

I believe it's related to throughput issue with Daytona/WebView2. Oddly enough ... I think it mostly happens on very powerful machines.

@andrasfuchs is your machine fairly powerful?

I thought I decreased the occurrence of this issue but I'll need to dig in more.

JakeRadMSFT commented 2 years ago

Also thanks so much for trying it out @andrasfuchs!! We'll work to resolve that feedback in the Notebooks.

andrasfuchs commented 2 years ago

@JakeRadMSFT Relatively yes, 6-core Ryzen 5 3600 CPU, 32 GB RAM, NVIDIA RTX 3070 Ti GPU. I'm not sure it matters, but I have many background processes running normally and my GPU is constantly under 90%+ load.

I don't know if it's related, but I noticed before a few times that during some Model Builder training sessions in Visual Studio the AutoML trainer started to eat up all the memory that I have left, and Windows started to hang more and more, so I needed to terminate the training process. I couldn't figure out how to reliably reproduce it though.

JakeRadMSFT commented 2 years ago

@andrasfuchs can you try out the latest version of the notebooks? Perf should be improved and the grey boxes should be gone :)

andrasfuchs commented 2 years ago

@JakeRadMSFT I'd love to, but I'm abroad for a few weeks and I have limited internet access. I'll get back to you when I'm home again.

andrasfuchs commented 2 years ago

@JakeRadMSFT Today I run the code snippets in the notebook again, and it got significantly better. The UI is more responsive, it feels quicker too.

I noticed four small, low-priority things:

I also experienced a Windows-hanging situation again that I suspect to be a memory-leak within the notebook, but I want to investigate it a little further. I think that is a more serious problem, so it's worth a separate issue. I'll create a new issue for that if I'm able to reproduce it a few more times.