search

dotnet / csharp-notebooks

Get started learning C# with C# notebooks powered by .NET Interactive and VS Code.
MIT License
995 stars 339 forks source link

Improve experience for deep-linking into Visual Studio/Visual Studio Code #54

Open nhirschey opened 2 years ago

nhirschey commented 2 years ago

Just noticed a small inconsistency, not sure if it's intentional.

When I click on C# 101 notebook links, they open .net interactive in vs code (with python set ast the kernel). When I click the ML.NET notebooks they open in visual studio 2022.

JakeRadMSFT commented 2 years ago

It is sort-of intentional but we are working on a way to get them consistent.

What are your thoughts on all links actually opening in GitHub but then at top of Notebook there are links to open in Visual Studio or Visual Studio Code.

We're also hoping that whichever notebook editor you're in ... when you click links that open another notebook ... it'll open it in the same editor host. For example, if you're in Visual Studio and click a link to a notebook it'll open it in a new tab in Visual Studio.

Thoughts?

nhirschey commented 2 years ago

What are your thoughts on all links actually opening in GitHub but then at top of Notebook there are links to open in Visual Studio or Visual Studio Code.

That would probably be my preference and I think it would be more familiar to people used to browsing python machine learning notebooks. When casually browsing github links, most of the time I just want to see the code in my browser.

That said, once I've seen the code and decided that I want to try it out, your "click a button to open in visual studio version X" experience is really nice. The F# ecosystem added a related feature to the top of documentation pages built with FSharp.Formatting (see DiffSharp example here) and it is really easy for newcomers to use.

JakeRadMSFT commented 2 years ago

I'll leave this open to track it! Thanks @nhirschey