search

dotnet / csharplang

The official repo for the design of the C# programming language
11.52k stars 1.02k forks source link

Do not use `in` as a synonym for `ref readonly` #1133

Closed mikedn closed 6 years ago

mikedn commented 6 years ago

ref readonly is a rather exotic language feature - it's only useful for certain optimizations and nothing else. The use of an innocuous and terse keyword such as in is simply not warranted and it looks like it is a significant source of confusion:

https://github.com/dotnet/csharplang/issues/1126 https://github.com/dotnet/corefx/issues/25355 https://github.com/dotnet/roslyn/issues/23327 https://github.com/dotnet/runtime/issues/77625

tannergooding commented 6 years ago

To be clear, it generally becomes too late a bit before RTW even, RTW just makes it a breaking change, officially.

The product and any features shipping are locked down and finalized well before the actual ship date and as the ship date approaches, the bar for getting a change in also gets higher.

MkazemAkhgary commented 6 years ago

Have fun with it https://github.com/dotnet/csharplang/issues/1133#issuecomment-346435396

HaloFour commented 6 years ago

@tannergooding

The product and any features shipping are locked down and finalized well before the actual ship date and as the ship date approaches, the bar for getting a change in also gets higher.

And before the design meeting notes on the subject are posted.

DavidArno commented 6 years ago

@tannergooding,

To be clear, it generally becomes too late a bit before RTW even, RTW just makes it a breaking change, officially.

Possibly just repeating @HaloFour's point here, but that is why the LDM notes need to be published in a timely fashion, before it is too late to canvas opinion on those design decisions.