[main] Update dependencies from dotnet/source-build-externals

dotnet / deployment-tools

This repo contains the code to build the .NET deployment tools and installers for all supported platforms, as well as the sources to .NET deployment tools.

MIT License

170 stars 51 forks source link

[main] Update dependencies from dotnet/source-build-externals #253

Closed dotnet-maestro[bot] closed 1 year ago

dotnet-maestro[bot] commented 1 year ago

This pull request updates the following dependencies

From https://github.com/dotnet/source-build-externals

Subscription: b901ab4b-a0fa-45dc-f1e6-08d9f733c371
Build: 20230313.1
Date Produced: March 13, 2023 10:16:48 PM UTC
Commit: 181f91eb28ecfb2e9a998efee1947aeb35baee1f
Branch: refs/heads/main
Updates:
- Microsoft.SourceBuild.Intermediate.source-build-externals: from 7.0.0-alpha.1.22114.1 to 8.0.0-alpha.1.23163.1

oleksandr-didyk commented 1 year ago

@NikolaMilosavljevic - I apologize for the ping, this PR is blocked by an invalid feed in NuGet.config. I would update it myself but unfortunately do not have write access to push into this branch. If need be I can of course merge the update from my own fork instead of re-using Darc's branch

-    <add key="dotnet7-transport" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet7-transport/nuget/v3/index.json" />
+    <add key="dotnet8-transport" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet8-transport/nuget/v3/index.json" />

We are trying to get source-build pre-build detection enabled in SDK-contributing repos, including deployment-tools. As part of that work, we would need this PR to be unblocked. Thanks!

NikolaMilosavljevic commented 1 year ago

@NikolaMilosavljevic - I apologize for the ping, this PR is blocked by an invalid feed in NuGet.config. I would update it myself but unfortunately do not have write access to push into this branch. If need be I can of course merge the update from my own fork instead of re-using Darc's branch
-    <add key="dotnet7-transport" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet7-transport/nuget/v3/index.json" />
+    <add key="dotnet8-transport" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet8-transport/nuget/v3/index.json" />
We are trying to get source-build pre-build detection enabled in SDK-contributing repos, including deployment-tools. As part of that work, we would need this PR to be unblocked. Thanks!

Should we keep both feeds for now? I see that model in other repos. Let me prepare the update that adds dotnet8-transport feed.

oleksandr-didyk commented 1 year ago

Thank you for the help!

Should we keep both feeds for now?

Sure thing. We will verify that externals was the only one using it and then open a PR removing it / do it as part of the pre-built PR