search

dotnet / deployment-tools

This repo contains the code to build the .NET deployment tools and installers for all supported platforms, as well as the sources to .NET deployment tools.
MIT License
170 stars 51 forks source link

Remove trimmable setting which is not supported in netstandard2.0 #294

Closed MichaelSimons closed 1 year ago

MichaelSimons commented 1 year ago

Fixes #288

According to https://learn.microsoft.com/en-us/dotnet/core/tools/sdk-errors/netsdk1195, trimming in only supported on netcoreapp3.0 and above. Microsoft.Deployment.DotNet.Releases targets netstandard2.0

MichaelSimons commented 1 year ago

cc @mthalman

MichaelSimons commented 1 year ago

Any suggestions how to catch trimming issues? This worked for me previously to catch issues

I don't know. If the project is not trimmable because it targets netstandard2.0, why do you care about catching trimming issues?

joeloff commented 1 year ago

It's used in a project that does support trimming and previously I got trim analyzer errors in that project for this dependency. Those are all addressed in the PR where I added the trim properties here - I had to fix up a bunch of STJ code in the library

MichaelSimons commented 1 year ago

It's used in a project that does support trimming and previously I got trim analyzer errors in that project for this dependency. Those are all addressed in the PR where I added the trim properties here - I had to fix up a bunch of STJ code in the library

That's a question for the trimming folks. All I know is this will cause a build error once this repo updates to build with rc1.

MichaelSimons commented 1 year ago

@joeloff, FYI, this is something I'd like to get into RC2 to eliminate a source-build patch.