search

dotnet / deployment-tools

This repo contains the code to build the .NET deployment tools and installers for all supported platforms, as well as the sources to .NET deployment tools.
MIT License
169 stars 50 forks source link

Include @dotnet/source-build-internal as code owners for SB files #319

Open ellahathaway opened 9 months ago

ellahathaway commented 9 months ago

@dotnet/source-build-internal is not tagged as a code owner for SourceBuildPrebuiltBaseline.xml. It would be helpful to create a CODEOWNERS file and include source-build-internal on SB files. For reference, Aspnet does this in their CODEOWNERS file: https://github.com/dotnet/aspnetcore/blob/36c976723fd0b55dad80f1ff32e665800ea4a021/.github/CODEOWNERS#L19

Having a code owners file would also be generally useful when opening PRs in this repo, as it can sometimes be difficult and time consuming to determine who should be included as a reviewer.

lbussell commented 9 months ago

Related issue: https://github.com/dotnet/arcade/issues/9555

NikolaMilosavljevic commented 8 months ago

[Triage] Approved - please fix.