search

dotnet / deployment-tools

This repo contains the code to build the .NET deployment tools and installers for all supported platforms, as well as the sources to .NET deployment tools.
MIT License
163 stars 50 forks source link

Dev/issue 237 #359

Closed jwwise-best closed 2 months ago

jwwise-best commented 3 months ago

This addresses the folder not found issue.

jwwise-best commented 3 months ago

@dotnet-policy-service agree

NikolaMilosavljevic commented 2 months ago

@jwwise-best is this needed in 8.0 servicing? Should this PR target main instead?

jwwise-best commented 2 months ago

The fix was developed against 8.0 but should apply to all later versions as well. I would target main, but it is behind the release and I did not want to contaminate the main branch with other release changes, and allow the merge back process to handle getting it back to main. How would you like me to proceed? Apply the change to main or leave this PR alone?

NikolaMilosavljevic commented 2 months ago

The fix was developed against 8.0 but should apply to all later versions as well. I would target main, but it is behind the release and I did not want to contaminate the main branch with other release changes, and allow the merge back process to handle getting it back to main. How would you like me to proceed? Apply the change to main or leave this PR alone?

Yeah, we don't want to bring any other changes from your branch. If you could cherry-pick this commit into a new branch and create a new PR for main, we could get this merged quickly.

jwwise-best commented 2 months ago

abandoning this PR for the updated one: https://github.com/dotnet/deployment-tools/pull/365