search

dotnet / diagnostics

This repository contains the source code for various .NET Core runtime diagnostic tools and documents.
MIT License
1.18k stars 355 forks source link

should_check_bgc_mark and fgc_should_consider_object need to be updated for regions #2208

Closed Maoni0 closed 1 year ago

Maoni0 commented 3 years ago

this was done so that we know whether we can verify deep while BGC sweep is going on. this should be updated for regions. or better yet, could we make these methods DACrized so we don't need to duplicate the code here?

mikem8361 commented 3 years ago

@Maoni0 is there anybody on your team that can fix this (and #2199)?

tommcdon commented 2 years ago

@cshung would you be able to help take a look?

leculver commented 1 year ago

These functions have moved to ClrMD so I'm taking this bug. Thanks!

hoyosjs commented 1 year ago

@leculver was this solved in the last PR you merged?

leculver commented 1 year ago

Not yet. This needs to be resolved in ClrMD itself now that we've stripped deep-GC knowledge out of SOS. I guess technically I could resolve this bug and open one within the ClrMD repo, but that's just more work.

I will resolve this as soon as the fix is in ClrMD and we merge that version of ClrMD into dotnet/diagnostics. (This is the next issue I am going to tackle after my current work goes into a PR.)

leculver commented 1 year ago

Fixed in: https://github.com/microsoft/clrmd/pull/1146.