search

dotnet / diagnostics

This repository contains the source code for various .NET Core runtime diagnostic tools and documents.
MIT License
1.18k stars 355 forks source link

The DumpGen SOS unit test is failed under USE_REGIONS #2451

Closed cshung closed 2 years ago

cshung commented 3 years ago

It looks like a possible cause is that we haven't implement https://github.com/microsoft/clrmd/issues/936 yet.

mikem8361 commented 3 years ago

Is there any way you could fix this?

cshung commented 3 years ago

In order to fix this bug, we need to

  1. Get the DAC to expose the data so that we can properly walk the heap under USE_REGIONS. https://github.com/dotnet/runtime/pull/56796 should fix it.

  2. Get CLRMD to expose the data so that DumpGen can access it. https://github.com/microsoft/clrmd/pull/945 should fix it.

  3. Get a new version of CLRMD published, and

  4. Get this repo to depends on the new version.

None of these is very difficult, I could fix them, but it will probably take some time before we can complete them all.

mikem8361 commented 3 years ago

Other than your current runtime PR (which hopefully can get merged before Tuesday) all of this sounds like out of band work in clrmd/diagnostics. I was hoping you could eventually do this work when you have time because the diagnostic team is a little overbooked and under staffed. If you can do this work (Lee can probably help with the clrmd work), please assign this issue to yourself.

cshung commented 2 years ago

I verified that https://github.com/dotnet/diagnostics/pull/2547 fixed the issue, the test is now passing for USE_REGIONS.