search

dotnet / diagnostics

This repository contains the source code for various .NET Core runtime diagnostic tools and documents.
MIT License
1.18k stars 354 forks source link

Update GCInfo deserializer once https://github.com/dotnet/runtime/pull/104336 merges #4795

Open VSadov opened 3 months ago

VSadov commented 3 months ago

https://github.com/dotnet/runtime/pull/104336 changes the encoding of GC info in a breaking way. (arm/arm64 code offsets are encoded with fewer bits)

Once the runtime change goes in, the SOS copy will need to be updated correspondingly, to be able to dump from GcInfo v3

Re: https://github.com/dotnet/runtime/pull/104336#discussion_r1664993184

tommcdon commented 2 months ago

Note: this change was reverted on https://github.com/dotnet/runtime/pull/105234

mikem8361 commented 1 month ago

@VSadov is the reverted runtime change going to eventually make it into .NET 9? Can I change this issue to .NET 10?

VSadov commented 1 month ago

Pushed out to dev10. Sorry, I forgot to change this issue once it was clear it is not going to make it into 9.

VSadov commented 1 month ago

Hmm, it does not look like i can change the milestone.