search

dotnet / diagnostics

This repository contains the source code for various .NET Core runtime diagnostic tools and documents.
MIT License
1.19k stars 355 forks source link

Target and Host cleanup #5018

Closed mikem8361 closed 3 weeks ago

mikem8361 commented 1 month ago

Cleanup and making error cases more bullet proof.

Change the context service ordering to prevent creating runtimes if not needed

Add a common Host.cs that impls IHost.

mikem8361 commented 3 weeks ago

Changes look good to me. Are there any tests/validation that could ensure no prior functionality was dropped? Yes, the SOS.UnitTests and .DebugServices.UnitTests test and validate this code/changes.