search

dotnet / diagnostics

This repository contains the source code for various .NET Core runtime diagnostic tools and documents.
MIT License
1.18k stars 354 forks source link

Some CLRMD APIs used in commands under dotnet-dump may fail #562

Closed mikem8361 closed 3 years ago

mikem8361 commented 5 years ago

The CLRMD APIs like stack trace, type resolution and GC heap dumping used by a dotnet-dump command for a Windows or Linux dumps may fail because the dump image may not contain the necessary module's data like metadata. The solution is to wrap the dump data reader's read memory functions and use the new memory service functions that find/download the runtime modules and maps them into the virtual address space.

This is similar to the problem described in issue https://github.com/dotnet/diagnostics/issues/503 for SOS commands.

hoyosjs commented 3 years ago

@mikem8361 is this still a concern?