Extract EventPipeEventSource from TraceEvent and make it part of Microsoft.Diagnostics.NetCore.Client

dotnet / diagnostics

This repository contains the source code for various .NET Core runtime diagnostic tools and documents.

MIT License

1.18k stars 354 forks source link

Extract EventPipeEventSource from TraceEvent and make it part of Microsoft.Diagnostics.NetCore.Client #803

Open davidfowl opened 4 years ago

davidfowl commented 4 years ago

There are a couple of reasons we should do this:

TraceEvent is large and has too many dependencies
It's unfortunate that the logic to read events isn't part of Microsoft.Diagnostics.NetCore. It's only job today is connect to the event pipe.

noahfalk commented 4 years ago

I would want to look into making a parser that can be shared between TraceEvent and non-TraceEvent scenarios, otherwise maintenance cost doubles to maintain independent implementations.

It's only job today is connect to the event pipe.

Not true : ) At the moment it also collects dumps and attaches ICorProfiler implementations. In the future it is likely to do more.