search

dotnet / dnceng

.NET Engineering Services
MIT License
25 stars 18 forks source link

Use `dotnet msbuild` for "Publish MatrixOfTruth API" step #1502

Open dougbu opened 10 months ago

dougbu commented 10 months ago

Inconsistently w/ other build steps in all dotnet-helix-machines pipelines, "Publish MatrixOfTruth API" in the Build job for dotnet-helix-machines-ci uses VSBuild@1 instead of DotNetCoreCLI@2. This currently causes a warning (shown below). More importantly, msbuild.exe seems completely unnecessary for this C# project and tends to perform worse than dotnet msbuild. Let's switch.

##[warning]D:\a\_work\_tool\dotnet\sdk\8.0.100\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.DefaultItems.targets(135,5): Warning NETSDK1213: Targeting .NET 8.0 or higher in Visual Studio 2022 17.7 is not supported.

Release Note Category

Release Note Description

Switched from msbuild.exe to dotnet msbuild in one of our build steps for consistency w/ the rest.

dougbu commented 10 months ago

/cc @ilyas1974 in case there are reasons why things are the way they are.

/cc @riarenas opening this issue reminded me that we might want to close the #536 epic and move the issues there to #376. We may also want to slightly expand the #376 title to better encompass the general care & feeding of the dotnet-helix-machines repo and its pipelines (which fits under the "Improve the reliability of PR and official builds," checkbox. Thoughts❔