dotnet / dnceng

.NET Engineering Services
MIT License
25 stars 19 forks source link

Move to Image Factory v3 II #2374

Closed dougbu closed 5 months ago

dougbu commented 7 months ago

Work in #2018 did not cover all interactions with Image Factory. Base image creation (what we do in the dotnet-helix-machines-image-generation pipeline) uses a completely different approach to image creation. CreateCustomImage doesn't apply here.

Many of the points from #2018 do apply (see below). However we'll need to manually update the base-images ARM templates and ImageFactoryCli to use the new pipeline.

Reference material

We would like to adopt the Image Factory v3 API for two primary reasons:

  1. To avoid getting left behind when DDFun removes v2.
  2. To improve the reliability of our image generation process. For example, generation of Linux images fail fairly frequently with errors like Status: The server rejected the request because too many requests have been received for this subscription. The v3 API may improve this situation.

Main points of reference are

Release Note Category

Release Note Description

Converted the rest of our interactions with the Image Factory service to use the v3 API.

dougbu commented 7 months ago

@markwilkie we never placed #2018 into an epic or treated it as an Ops issue. How should we categorize this follow-on issue and anything we might want to do about the Microsoft.ImageFactory.SDK package❔

I'm filing a Microsoft.ImageFactory.SDK issue now&helliip;

dougbu commented 6 months ago

Fixed with !39175 but needs a correction. See #2677 for that correction.

dougbu commented 5 months ago

done