dotnet / docfx

Static site generator for .NET API documentation.
https://dotnet.github.io/docfx/
MIT License
3.94k stars 839 forks source link

chore: Change actionbar button style attribute to css #10020

Closed filzrev closed 2 weeks ago

filzrev commented 2 weeks ago

This PR move ActionBar button's style attribute to layout.scss. (ActionBar button is displayed on mobile view)

This change is required to suppress errors that occurs on CSP(Content-Security Policy) enabled environment. (e.g. #10018)

Almost of CSP errors can be suppressed by explicitly specifying hash-source. But style attributes can not suppressed by this setting. And following following message is displayed.

Either the 'unsafe-inline' keyword, a hash ('sha256-hrMAdouS/Nq0Km7HyvR/ocksu2luFnpaxSswePO7FOY='), or a nonce ('nonce-...') is required to enable inline execution. Note that hashes do not apply to event handlers, style attributes and javascript: navigations unless the 'unsafe-hashes' keyword is present.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.86%. Comparing base (fe673ec) to head (eef630e). Report is 209 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #10020 +/- ## ========================================== + Coverage 74.31% 78.86% +4.54% ========================================== Files 536 540 +4 Lines 23189 23479 +290 Branches 4056 4066 +10 ========================================== + Hits 17234 18516 +1282 + Misses 4853 3822 -1031 - Partials 1102 1141 +39 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.