dotnet / docfx

Static site generator for .NET API documentation.
https://dotnet.github.io/docfx/
MIT License
3.95k stars 842 forks source link

feat: Remove Node.js runtime dependencies from docfx tools #10066

Closed filzrev closed 1 week ago

filzrev commented 1 week ago

This PR intended to resolve #9396.

Background

Playwright 1.41 or later supports following environment variables. (It's not documented though)

So it can remove Node.js runtime from docfx package. Instead. it can use locally installed Node.js runtime instead.

By this changes. docfx packages size can be reduced from 208MB -> 56 MB

BREAKING CHANGES This PR remove Node.js runtime bundles. So it may introduce breaking changes for some users who using docfx without Node.js installation. (e.g. docker image users)

I'll try to fix official docker image later. https://github.com/dotnet/docfx/blob/main/Dockerfile

filzrev commented 1 week ago

When using CommandUtility.ExistCommand helper methods. It need to handle stdout result parse logics. Because of following reasons.

So I've reverted code to PATH based search logics.