dotnet / docfx

Static site generator for .NET API documentation.
https://dotnet.github.io/docfx/
MIT License
4.09k stars 866 forks source link

Prevent the first navbar element from being set as active unnecessarily in the modern template #10204

Closed KubaZ2 closed 2 months ago

KubaZ2 commented 2 months ago

Fixes #9877

filzrev commented 2 months ago

This PR introduce some behavior changes on existing docfx site.

Currently if there is no matching navigation element exists. first element is selected by default. But after this PR merged. no element is activated.

Example URLs

When opening above URLs. Docs navigation is activated before PR is merged. But after this PR is merged. no navigation element is activated.

I'm not particularly concerned about the differences in behavior. But it should be documented as BREAKING CHANGES on release note.