search

dotnet / docfx

Static site generator for .NET API documentation.
https://dotnet.github.io/docfx/
MIT License
4.06k stars 865 forks source link

[Bug] PDF Download not appearing for nested TOC #10338

Open kontax85 opened 1 week ago

kontax85 commented 1 week ago

Describe the bug Using nested TOCs the Download PDF is not available. The PDF files are correctly generated. The download PDF option appears only when the master TOC has PDF generation enabled.

To Reproduce Content of docfx.json:

"globalMetadata": { "pdfTocPage": true }

Content of the master TOC:

items:

  • name: Italian Bank Integration href: ItalianBankIntegration/toc.yml homepage: ItalianBankIntegration/intro.md

Content of the nested TOC:

pdf: true pdfFileName: ItalianBankIntegration.pdf pdfCoverPage: covers/ItalianBankIntegration.html href: intro.md items:

  • name: XXX href: XXX.md

The template is modern.

Expected behavior The PDF Download option should appear in the bottom left area when selecting the menu area related to this TOC.

Context (please complete the following information):

lanthonyneville commented 1 week ago

This sounds like what I reported in #10329 ... do you agree?

kontax85 commented 4 days ago

Hi @lanthonyneville , actually I don't think that it is the same issue, the left pane in my case is rendered (the TOC is visible) but there is no PDF Download Link navigating the nested TOC.

Image

lanthonyneville commented 3 days ago

Hi @lanthonyneville , actually I don't think that it is the same issue, the left pane in my case is rendered (the TOC is visible) but there is no PDF Download Link navigating the nested TOC.

Yes, its different.