Closed filzrev closed 3 days ago
This PR intended to fix issue #10398. By temporary revert commit (https://github.com/dotnet/docfx/pull/9363)
Background When using PLAYWRIGHT_NODEJS_PATH environment variable. ../../.playwright fallback from bin directory is not used. And failed to find .playwright\package\cli.js file.
PLAYWRIGHT_NODEJS_PATH
../../.playwright
.playwright\package\cli.js
To fix problems. it need to change playwright-dotnet side code (or install chromium browser directly by calling .playwright/package/cli.js)
playwright-dotnet
.playwright/package/cli.js
So I've temporary reverted #9363 code. And place .playwright folder under bin directory. By this changes. .nupkg size increased about 1.8MB.
.playwright
.nupkg
1.8MB
This PR intended to fix issue #10398. By temporary revert commit (https://github.com/dotnet/docfx/pull/9363)
Background When using
PLAYWRIGHT_NODEJS_PATH
environment variable.../../.playwright
fallback from bin directory is not used. And failed to find.playwright\package\cli.js
file.To fix problems. it need to change
playwright-dotnet
side code(or install chromium browser directly by calling
.playwright/package/cli.js
)So I've temporary reverted #9363 code. And place
.playwright
folder under bin directory. By this changes..nupkg
size increased about1.8MB
.