search

dotnet / docfx

Static site generator for .NET API documentation.
https://dotnet.github.io/docfx/
MIT License
4.09k stars 867 forks source link

fix: Bootstrap variable override problem #10412

Closed filzrev closed 1 day ago

filzrev commented 1 day ago

This PR intend to fix issue #10411

What's changed

  1. Remove SCSS variable override. Instead, directly pass SCSS variable override by with Configuration syntax.
  2. Remove $enable-important-utilities: false; setting.

Background

PR #10301 changes @import statement to @use statement to suppress following warnings.

[WARNING] Sass @import rules are deprecated and will be removed in Dart Sass 3.0.0.

These changes are automatically refactored by using sass-migrator command. But after these changes. It seems SCSS variable override is not works as expected. And regression seems not detected by percy visual regression tests. Because percy tests with following display resolution widths (375px/1280px)