dotnet / docfx

Static site generator for .NET API documentation.
https://dotnet.github.io/docfx/
MIT License
4.09k stars 867 forks source link

[Bug] Since 2.78 docfx fails if node.js is not found even when not generating pdf #10415

Closed kschelfthoutelement closed 1 day ago

kschelfthoutelement commented 1 day ago

Describe the bug I understand node.js was removed from the DocFx package since v2.78. I also understand from the documentation that node.js should only be necessary when generating pdf.

Yet, I set "pdf": false in my config and I still get the exception. (I do indeed not have node.js installed)

To Reproduce Steps to reproduce the behavior:

  1. Part of config:
{
  "build": {
    "globalMetadata": {
      "pdf": false
    }
  }
}
  1. dotnet tool run docfx docfx.json

Exception complaing about node.js

Also tried adding pdf: false to my toc, didn't make any difference.

Expected behavior

Docfx generates the html

Context (please complete the following information):

Additional context

filzrev commented 1 day ago

Reported issue is resolved by #10406. But it's not released yet.

kschelfthoutelement commented 1 day ago

Great! Sorry I missed that. Thanks for the quick turnaround.