Open filzrev opened 1 month ago
Attention: Patch coverage is 86.66667%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 78.81%. Comparing base (
fe673ec
) to head (9d56541
). Report is 211 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
src/Docfx.Build/TableOfContents/TocHelper.cs | 86.66% | 1 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR is intended to fix internal exception that occurred when deserializing
toc.yml
file.Current docfx implementation use
YamlDeserializerWithFallback
class to deserializetoc.yml
file. And following operation executed.List<TocItemViewModel>
.TocItemViewModel
.This PR intended to fix following problems.
try-catch
logics are used when deserializingTocItemViewModel
asList<TocItemViewModel>
.-> Exceptions should not be thrown in the normal execution flow.
TocItemViewModel
. It requires to open safe file twice.