Open filzrev opened 1 month ago
Attention: Patch coverage is 53.84615%
with 6 lines
in your changes are missing coverage. Please review.
Project coverage is 78.91%. Comparing base (
fe673ec
) to head (0051a98
). Report is 183 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR intended to fix issue #8967
Currently when both
output
anddest
properties are specified. It's resolved to{baseDir}/{output}/{dest}
path.It cause problems when specifying
dest
on config and using--output
parameter.This PR changes this behavior to use
output
if it's specified by config/parameter. And only use thedest
property if the `output' parameter is not specified.Additionally following changes are included in this PR.
[Obsolete]
attribute todest
property.dest
property. So it shouldn be removed after Json schema validation logics are integrated.dest
property. And add warning suppressions that usedest
property.new TemplateManager
's constructor parameter to usebaseDirectory
(No behavior changes)optionsBaseDirectory
variable and comments.