Closed mthalman closed 1 year ago
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.
Do you have a sense of the build time impact of these changes?
It's not too bad. I would estimate for a full build it'll end up adding less than a minute of extra time.
As part of the publish process we push manifest list tags and then query them to get their digests. The code which queries for the digests does so by executing all the requests in parallel. When Image Builder was based on .NET 6, we would periodically see the following exception when executing that code:
But that happened very infrequently with .NET 6. Now that Image Builder has been upgraded to .NET 7, an exception occurs nearly all the time. But with .NET 7, there's a NRE that's occurring:
This appears to be a bug with .NET. I'm able to repro locally and debug through things but am unable to determine the root cause. I will try to get a standalone repro for this and get an issue logged in dotnet/runtime and point back here.
In the meantime, I've changed the logic to no longer execute these requests concurrently. That allows execution to successfully complete and doesn't impact the execution time too bad.