search

dotnet / docker-tools

This is a repo to house some common tools for our various docker repos.
MIT License
124 stars 46 forks source link

Image Builder Dockerfile references .NET 6 runtime-deps #1113

Closed mthalman closed 1 year ago

mthalman commented 1 year ago

The changes from https://github.com/dotnet/docker-tools/pull/1104 updated Image Builder to .NET 7. But the Dockerfile continues to reference the .NET 6 image name of runtime-deps: https://github.com/dotnet/docker-tools/blob/bf5e6ad6053b16d023b4021bef892403783709d2/src/Microsoft.DotNet.ImageBuilder/Dockerfile.linux#L27

Technically, the .NET 6 and .NET 7 runtime-deps image names refer to the same image. So this is currently functionally correct. However, we should update the image name to reflect the actual .NET version being targeted.

dotnet-issue-labeler[bot] commented 1 year ago

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.