search

dotnet / docker-tools

This is a repo to house some common tools for our various docker repos.
MIT License
122 stars 46 forks source link

Change tagging from parallel to serial #1117

Closed mthalman closed 1 year ago

mthalman commented 1 year ago

Lately there have been random build timeouts popping up at the point where the build command tags cached images. It's not clear what is hanging. It could either be a deadlock of some kind in ImageBuilder's caching code (which seems unlikely since that code hasn't changed) or maybe a new version of Docker that doesn't tolerate parallel tagging operations very well, or maybe something else.

Regardless, this should be fixed by changing the logic to create the tags serially rather than in parallel.

MichaelSimons commented 1 year ago

Curious what the impact is to the build times?

mthalman commented 1 year ago

Curious what the impact is to the build times?

It's very negligible. A given tag operation only takes about 1/10 of a second. At worse, we might have 100 tags to create in a given job. That amounts to 10 secs.