search

dotnet / docker-tools

This is a repo to house some common tools for our various docker repos.
MIT License
122 stars 46 forks source link

Allow passing docker secret mounts through ImageBuilder #1133

Closed lbussell closed 1 year ago

lbussell commented 1 year ago

I tried to make the new CliHelper Option and the build command arguments more general. I'm working on the tests now.

dotnet-issue-labeler[bot] commented 1 year ago

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

mthalman commented 1 year ago

@lbussell - Can you post an example of what the syntax looks like for making use of this new option? That would be helpful.

lbussell commented 1 year ago

@lbussell - Can you post an example of what the syntax looks like for making use of this new option? That would be helpful.

Yes, the syntax should be exactly the same as the docker syntax - 

--secret id=<your secret's id>,src=<your literal secret or secret file>

https://dev.azure.com/dnceng/internal/_git/dotnet-dotnet-docker?path=/eng/pipelines/stages/build-test-publish-repo.yml&version=GBdev/loganbussell/fips2&line=48&lineEnd=49&lineStartColumn=1&lineEndColumn=1&lineStyle=plain&_a=contents (internal link)

lbussell commented 1 year ago

This feature is being put on hold and we can re-open this PR if we need it in the future.