search

dotnet / docker-tools

This is a repo to house some common tools for our various docker repos.
MIT License
122 stars 46 forks source link

Remove workaround for BuildKit Dockerfile caching issue #1174

Open lbussell opened 1 year ago

lbussell commented 1 year ago

A workaround was added in https://github.com/dotnet/docker-tools/pull/1173:

https://github.com/dotnet/docker-tools/blob/965b56f5131e80746c7dfce99b22785a73f58de2/src/Microsoft.DotNet.ImageBuilder/src/DockerService.cs#L93-L98

According to the Docker release notes, the issue is resolved in Docker Engine version 23: https://github.com/moby/buildkit/issues/1368

This workaround should be removed once our Azure build agents have Docker Engine v23.0.0.

dotnet-issue-labeler[bot] commented 1 year ago

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

lbussell commented 2 months ago

[Triage] This should be fixed since we have a newer Docker version in ImageBuilder now.