search

dotnet / docker-tools

This is a repo to house some common tools for our various docker repos.
MIT License
122 stars 46 forks source link

File Pusher project returns exit code 0 even when there is an unhandled exception #1224

Closed lbussell closed 5 months ago

lbussell commented 6 months ago

Steps to reproduce the issue

  1. Run the file pusher project with no arguments to get an unhandled exception. dotnet run -- any or no arguments work here
  2. Observe the unhandled exception
  3. Check $LastExitCode using pwsh, it is 0

Expected behavior

$LastExitCode should be 1

dotnet-issue-labeler[bot] commented 6 months ago

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

lbussell commented 6 months ago

[Triage] We should take a look at how the update-dependencies project handles exiting with a non-zero error code: https://github.com/dotnet/dotnet-docker/blob/8173c8f98f4ee16cf310a8f1f94283b230d8002a/eng/update-dependencies/UpdateDependencies.cs#L100-L104