search

dotnet / docker-tools

This is a repo to house some common tools for our various docker repos.
MIT License
122 stars 46 forks source link

Move 1ES PT image definition inside internal project conditional #1226

Closed lbussell closed 6 months ago

lbussell commented 6 months ago

From the expanded yaml I downloaded from our PR validation pipeline, this code used to expand to: 

    pool:
      image: Mariner-2-Docker-ARM64
      os: linux
      hostArchitecture: Arm64
      name: Docker-Linux-Arm-Public

This is invalid since the only image in that pool is Ubuntu-20.04-Docker-ARM64. Azure DevOps silently ignores incorrect image name requests, making this YAML misleading.

Related: https://github.com/dotnet/docker-tools/pull/1215#discussion_r1529470841

Test run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2408331&view=results