Remove certain instances of Docker image cleanup

dotnet / docker-tools

This is a repo to house some common tools for our various docker repos.

MIT License

122 stars 46 forks source link

Remove certain instances of Docker image cleanup #1229

Closed lbussell closed 6 months ago

lbussell commented 6 months ago

Part of #1213

These changes are intended to...

Remove the Docker cleanup step:

From the end of pipeline runs
Before pre-build validation and matrix generation

Leave the cleanup step:

Before building any images
Before mirroring/pulling any base images

Test run (still running at time of submission, but it's been through a few iterations): https://dev.azure.com/dnceng/internal/_build/results?buildId=2412187&view=results

lbussell commented 6 months ago

@mthalman thoughts on changing the default value of cleanupDocker to false? It really only needs to be set in builds. Would save some lines of code over what's in this PR.

mthalman commented 6 months ago

@mthalman thoughts on changing the default value of cleanupDocker to false? It really only needs to be set in builds. Would save some lines of code over what's in this PR.

Yes, that sounds like a good idea.

lbussell commented 6 months ago

New test run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2413966&view=results [internal link]