search

dotnet / docker-tools

This is a repo to house some common tools for our various docker repos.
MIT License
122 stars 46 forks source link

OS Version formatting for distroless is inconsistent and the hyphen usage could be improved #1248

Closed MichaelSimons closed 5 months ago

MichaelSimons commented 5 months ago

See https://hub.docker.com/_/microsoft-dotnet-runtime-deps/ and look for distroless.

CBL-Mariner 2.0-distroless
  1. It feels a bit inconsistent that distroless is called out but chiselled is not. It feels like either both should be called out or neither.
  2. I find the formatting to be odd. Specifically the hyphen e.g. 2.0-distroless. CBL-Mariner 2.0 (distroless) or CBL-Mariner 2.0 Distroless IMO is a better format. The current format feels more strange with the introduction of Azure Linux 3.0-distroless images.
lbussell commented 5 months ago

[Triage]

  1. We should remove the distroless suffix since all the information is already in the tag. The primary use of the OS Version column for us is decoding OS codenames e.g. Bookworm or Jammy.
  2. Since we'll remove the distroless suffix, this is not applicable.
MichaelSimons commented 5 months ago

This is not an issue with docker-tools, rather an issue with the osversion specified in the manifest in dotnet-docker.

MichaelSimons commented 5 months ago

Scratch that last comment.