search

dotnet / docker-tools

This is a repo to house some common tools for our various docker repos.
MIT License
122 stars 46 forks source link

[main] Update Image Builder tag reference #1251

Closed dotnet-docker-bot closed 5 months ago

dotnet-docker-bot commented 5 months ago

Updates the common pipeline variables to reference an updated tag of Image Builder.

dotnet-issue-labeler[bot] commented 5 months ago

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

lbussell commented 5 months ago

Waiting on https://github.com/microsoft/dotnet-framework-docker/pull/1121 before merging.

mthalman commented 5 months ago

This contains the changes from https://github.com/dotnet/docker-tools/pull/1252. It'd be good to validate that in nightly before rolling out elsewhere.

mthalman commented 5 months ago

This contains the changes from #1252. It'd be good to validate that in nightly before rolling out elsewhere.

Oh, excellent. It already caused a failure here.

mthalman commented 5 months ago

/azp run docker-tools-eng-validation-pr

azure-pipelines[bot] commented 5 months ago
Azure Pipelines successfully started running 1 pipeline(s).
lbussell commented 5 months ago

@mthalman did you just add the placeholder tenant variables directly to the pipeline?

Is there a reason they shouldn't be added at the yaml level, conditioned on whether or not we are running in public CI?

mthalman commented 5 months ago

@mthalman did you just add the placeholder tenant variables directly to the pipeline?

Is there a reason they shouldn't be added at the yaml level, conditioned on whether or not we are running in public CI?

Sure, I'll add it to YAML instead.