search

dotnet / docker-tools

This is a repo to house some common tools for our various docker repos.
MIT License
124 stars 46 forks source link

Migrate Import Image to use Azure.ResourceManager.ContainerRegistry #1252

Closed mthalman closed 6 months ago

mthalman commented 6 months ago

This migrates the "Import Image" logic from the deprecated Azure Fluent API to the modern Azure.ResourceManager.ContainerRegistry package.

This affects the functionality of the copyAcrImages and copyBaseImages commands. I've tested both of those commands with these changes and they're both working.

Overall, it's a pretty straightforward 1:1 migration. Just a new API to adjust to.

dotnet-issue-labeler[bot] commented 6 months ago

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

mthalman commented 6 months ago

/azp run docker-tools-imagebuilder-pr

azure-pipelines[bot] commented 6 months ago
Azure Pipelines successfully started running 1 pipeline(s).
mthalman commented 6 months ago

/azp run docker-tools-eng-validation-pr

azure-pipelines[bot] commented 6 months ago
Azure Pipelines could not run because the pipeline triggers exclude this branch/path.
lbussell commented 6 months ago

Part of https://github.com/dotnet/docker-tools/issues/1176 and https://github.com/dotnet/docker-tools/issues/1123