search

dotnet / docker-tools

This is a repo to house some common tools for our various docker repos.
MIT License
122 stars 46 forks source link

Use service connection for ACR auth #1260

Closed dotnet-docker-bot closed 4 months ago

dotnet-docker-bot commented 5 months ago

Updates the common pipeline variables to reference an updated tag of Image Builder.

dotnet-issue-labeler[bot] commented 5 months ago

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

lbussell commented 5 months ago

(Changes are WIP - Internal pipelines are being slow so pushing my changes here early)

lbussell commented 4 months ago

It is also worth noting that the Windows code is not exercised here - that will only need to work when we update the Build command.

lbussell commented 4 months ago

I'm running this ahead in dotnet-docker-nightly and running into one issue with authentication: https://dev.azure.com/dnceng/internal/_build/results?buildId=2443330&view=logs&j=1a3858d4-df16-5910-9f2f-b79bed34300b&t=19b48826-3918-580e-74d6-f5452db20ad6&l=463

lbussell commented 4 months ago

This is all tested and working and ready for review now.