search

dotnet / docker-tools

This is a repo to house some common tools for our various docker repos.
MIT License
122 stars 46 forks source link

Remove project name parameters from pipeline templates #1267

Open mthalman opened 5 months ago

mthalman commented 5 months ago

This PR (https://github.com/dotnet/docker-tools/pull/884) introduce a template pattern where internalProjectName and publicProjectName parameters were defined and passed around to templates rather than hardcoding the actual AzDO project names:

https://github.com/dotnet/docker-tools/blob/86df1f66c815ed8bc35c50147228d003aadcd9b7/eng/common/templates/stages/build-test-publish-repo.yml#L22-L23

This pattern doesn't provide much value. In fact, it has negative value because developers need to ensure that these values get passed around through the template graph. Omitting this can lead to unintended behavior. We should consider removing these parameters and simply hardcoding the project names where they are needed.

dotnet-issue-labeler[bot] commented 5 months ago

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

lbussell commented 1 month ago

[Triage] This is something we can work on incrementally - as we make changes to existing pipelines we should feel free to replace these variables where appropriate.