search

dotnet / docker-tools

This is a repo to house some common tools for our various docker repos.
MIT License
122 stars 46 forks source link

Fix various issues with new ImageBuilder pipeline step templates #1268

Closed lbussell closed 4 months ago

lbussell commented 4 months ago

Fixes various issues from https://github.com/dotnet/dotnet-docker/pull/5421.

There is still one outstanding issue - our Windows agents don't have Az CLI installed. That is currently being addressed at the VM image level but I am working on a workaround now. This PR will fail internal Windows builds until that is addressed so this is in draft mode.

dotnet-issue-labeler[bot] commented 4 months ago

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

lbussell commented 4 months ago

Windows VM Images are updated to contain Az CLI and I fixed some additional bugs, everything seems to be working now! Test run [internal link]

lbussell commented 4 months ago

@mthalman Appears to be working: https://github.com/dotnet/dotnet-docker/pull/5437

This pull request's pipeline runs are also evidence of that.

mthalman commented 4 months ago

@mthalman Appears to be working: dotnet/dotnet-docker#5437

This pull request's pipeline runs are also evidence of that.

That one has an error in CopyBaseImages though: https://dev.azure.com/dnceng-public/public/_build/results?buildId=666898&view=logs&jobId=5e8a216f-208e-5f25-daac-ba5cedb89a59&j=1a3858d4-df16-5910-9f2f-b79bed34300b&t=cbac5fd7-97ef-5b4a-4622-7378ec20d382

lbussell commented 4 months ago

@mthalman Appears to be working: dotnet/dotnet-docker#5437 This pull request's pipeline runs are also evidence of that.

That one has an error in CopyBaseImages though: https://dev.azure.com/dnceng-public/public/_build/results?buildId=666898&view=logs&jobId=5e8a216f-208e-5f25-daac-ba5cedb89a59&j=1a3858d4-df16-5910-9f2f-b79bed34300b&t=cbac5fd7-97ef-5b4a-4622-7378ec20d382

Oops, it had some outdated changes. It's running again now.

mthalman commented 4 months ago

But you're right, this PR's build is essentially doing the same thing and it's running clean.

lbussell commented 4 months ago

Successful public run: https://dev.azure.com/dnceng-public/public/_build/results?buildId=666933&view=results